Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone codebase validation #568

Closed
callmevladik opened this issue Jan 23, 2025 · 0 comments · Fixed by #569
Closed

Fix clone codebase validation #568

callmevladik opened this issue Jan 23, 2025 · 0 comments · Fixed by #569
Assignees
Labels
bug Something isn't working

Comments

@callmevladik
Copy link
Contributor

callmevladik commented Jan 23, 2025

When a user attempts to create a component using the clone strategy and opts to use repository credentials by checking the "repository credentials" checkbox, the system correctly displays a warning message if the repository login or password input fields are left empty. However, the issue arises as the user can still proceed to create the component despite the warning, which should not be permissible.

Steps to Reproduce:

  1. Navigate to the component creation page.
  2. Select the clone strategy for component creation.
  3. Activate the "repository credentials" checkbox.
  4. Leave the repository login and/or password input fields empty.
  5. Observe the warning message but proceed to create the component.

Expected Result:
The system should prevent the user from creating the component when the repository credentials are incomplete or not provided, even if the "repository credentials" checkbox is active.

Actual Result:
The user is able to create the component with incomplete repository credentials despite the warning message.

@callmevladik callmevladik converted this from a draft issue Jan 23, 2025
@callmevladik callmevladik self-assigned this Jan 23, 2025
@callmevladik callmevladik added the bug Something isn't working label Jan 23, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in KubeRocketCI Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant