Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clean deploy pipeline creation #463

Closed
callmevladik opened this issue Nov 6, 2024 · 0 comments · Fixed by #464
Closed

Update clean deploy pipeline creation #463

callmevladik opened this issue Nov 6, 2024 · 0 comments · Fixed by #464
Assignees
Labels
enhancement New feature or request

Comments

@callmevladik
Copy link
Contributor

callmevladik commented Nov 6, 2024

As part of our continuous efforts to improve the user experience on the Portal UI, there is a need to update the logic for clean pipelines. The updated logic should specifically target and update existing values derived from the TriggerTemplate for CDSTAGE and CDPIPELINE, while ignoring other values. This ensures that only relevant pipeline information is processed, enhancing efficiency and accuracy.

The TriggerTemplate values to be updated are as follows:

  • name: CDSTAGE
    value: $(tt.params.CDSTAGE)
  • name: CDPIPELINE
    value: $(tt.params.CDPIPELINE)

This task involves modifying the underlying code to implement this logic.

Acceptance Criteria

  1. The Portal UI logic correctly searches for and updates the CDSTAGE and CDPIPELINE values from the TriggerTemplate.
  2. Other values in the TriggerTemplate are skipped and left unchanged.
  3. The updated logic does not affect the performance or other functionalities of the Portal UI.
  4. Adequate unit tests are added to cover the new logic.
  5. Documentation is updated to reflect the changes in the logic.
@callmevladik callmevladik converted this from a draft issue Nov 6, 2024
@callmevladik callmevladik self-assigned this Nov 6, 2024
@callmevladik callmevladik added the enhancement New feature or request label Nov 6, 2024
@SergK SergK closed this as completed in #464 Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in KubeRocketCI Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant