Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update approve/reject #423

Closed
callmevladik opened this issue Oct 11, 2024 · 0 comments · Fixed by #424
Closed

Update approve/reject #423

callmevladik opened this issue Oct 11, 2024 · 0 comments · Fixed by #424
Assignees
Labels
enhancement New feature or request feature New functionality

Comments

@callmevladik
Copy link
Contributor

callmevladik commented Oct 11, 2024

The Portal UI currently lacks the functionality to automatically set the 'ApprovedBy' field for custom approval tasks. There's also a need to allow users to add a custom description to their approval action in a 'comment' field. The following changes are required to enhance the approval process:

  1. Automatically Set 'ApprovedBy' Field: The Portal UI should be enhanced to automatically grab the user's information from the token at the time of task approval and set this information in the 'ApprovedBy' field of the custom approval task.

  2. Custom Comment Field: Provide an option for users to input a custom description for their approval action. This input should be captured in a 'comment' field associated with the approval task.

Acceptance Criteria
The 'ApprovedBy' field is automatically populated with the username who approved the task, extracting this information from the user's token.
A 'comment' field is available for users to input a custom description of their approval action.
The Portal UI correctly displays and saves the 'ApprovedBy' information and the custom comment without errors.
Ensure compatibility with existing task approval workflows.
Implementation Plan

  1. Update the Portal UI to capture and process user token information to autofill the 'ApprovedBy' field during approval actions.
  2. Implement a text input field for custom comments in the approval section of the UI.
  3. Test the new functionality with various user tokens and comments to ensure reliability and compatibility.
  4. Deploy changes to the staging environment for further testing.
  5. Upon successful testing, deploy the update to the production environment.

spec:
action: Approved
approve:
approvedBy: sergiy_kulanov@epam.com
comment: No objections
description: Promote versions to the next Environment?

Related change in custom task https://github.com/KubeRocketCI/tekton-custom-task/pull/17/files

@callmevladik callmevladik converted this from a draft issue Oct 11, 2024
@callmevladik callmevladik self-assigned this Oct 11, 2024
@callmevladik callmevladik added enhancement New feature or request feature New functionality labels Oct 11, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in KubeRocketCI Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New functionality
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant