Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR/MR column into PipelineRuns table #304

Closed
callmevladik opened this issue Jul 22, 2024 · 0 comments · Fixed by #305 or #306
Closed

Add PR/MR column into PipelineRuns table #304

callmevladik opened this issue Jul 22, 2024 · 0 comments · Fixed by #305 or #306

Comments

@callmevladik
Copy link
Contributor

callmevladik commented Jul 22, 2024

Description:
The Pipelines table in UI Portal requires a new column to display Pull Requests. This column will present data obtained from the changeNumber parameter of the code review pipeline. If the changeNumber parameter is not available for a particular entry, the item should be left empty. The new column should be positioned after the 'Run' column and before the 'Pipeline' column. The Pull Request number should be presented as a link pointing to the corresponding pull request. This task also includes a review of methods to construct the URL for the pull request links in a simple and efficient manner.

Acceptance Criteria:

  1. A new column titled 'Pull Request' is added to the Pipelines table in EDP Headlamp.
  2. The column accurately displays the changeNumber as a link to the corresponding pull request when available.
  3. If the changeNumber parameter is not available, the column for that entry remains empty.
  4. The 'Pull Request' column is positioned correctly between the 'Run' and 'Pipeline' columns.
  5. The method for constructing pull request URLs is reviewed and implemented in the most efficient way.
  6. The feature is tested to ensure accuracy and functionality across various cases.

Implementation Plan:

Modify the Pipelines table component to include a new column for Pull Requests.
Implement logic to fetch and display the changeNumber as a hyperlink to the pull request, ensuring the link is constructed correctly.
Ensure the new column is correctly positioned within the table layout.
Review and decide on the most efficient method for constructing pull request URLs, considering the structure of available data and the platform hosting the pull requests.
Conduct thorough testing of the new column to ensure it functions correctly and displays accurately across various scenarios.
Submit the changes for review and merge them upon approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant