-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Pydantic V2 models when possible instead of defaulting to Pydantic V1 models #222
Open
adubovik
wants to merge
40
commits into
development
Choose a base branch
from
feat/compatibility-with-pydantic-v2
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feb1b25
to
e5e3f25
Compare
6295e9b
to
73d77ac
Compare
12df9f3
to
03d6106
Compare
fd4ee29
to
69637d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #220
Currently, DIAL SDK produces the Pydantic v1 models even when Pydantic v2 is installed:
The fix introduces
PYDANTIC_V2
environment variable to control the version of Pydantic models used when Pydantic v2 is installed.So when
PYDANTIC_V2=True
:By default,
PYDANTIC_V2
is set toFalse
to maintain backward compatibility.