Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split view via unified coordinates and search control #706

Closed
NShaforostov opened this issue Dec 9, 2021 · 4 comments
Closed

Split view via unified coordinates and search control #706

NShaforostov opened this issue Dec 9, 2021 · 4 comments
Assignees
Labels
kind/enhancement New feature or request state/has-doc Issues that have documentation sys/gui Issues related to the web gui

Comments

@NShaforostov
Copy link
Collaborator

NShaforostov commented Dec 9, 2021

Background

Currently, NGB supports split view for the Browser panel, e.g. to open mate regions of pair alignments or show pair for inter-chromosomal variants.
It could be convenient to expand this functionality and allow users to split browser for any location of interest - via the unified coordinates and search control.

Approach

  • Add the support of specifying two pairs of coordinates in the unified coordinates and search control:
    • in this case, user will specify two pairs of coordinates separated by space to the coordinates field and confirm the input by the Enter key. After that, a second browser pane should be opened - in the main pane, the first specified location should be displayed, in the second pane - the second location (similar behavior to the current split view), e.g.:
      image
      image
    • shall be supported the following formats for each location:
      • "coordinates" formats:
        • <COORDINATE> - the location shall be opened on the current chromosome and have the specified coordinate as central position
        • <START_COORDINATE>-<FINISH_COORDINATE> - the location shall be opened on the current chromosome and have the specified coordinates as location boundaries
        • <CHR_NAME>:<COORDINATE> - the location shall be opened on the specified chromosome and have the specified coordinate as central position
        • <CHR_NAME>:<START_COORDINATE>-<FINISH_COORDINATE> - the location shall be opened on the specified chromosome and have the specified coordinates as location boundaries
      • "feature" formats:
        • <FEATURE_NAME> - a gene, transcript, feature name. Shall be opened the first location from search result list
      • locations can be separated by any count of spaces
    • the unified coordinates and search control in the additional browser pane shall be disabled to changing (same behavior to the current split view). If user will change location in the "main" browser pane - this location shall be opened in the "main" browser pane and the additional browser pane (split view) shall be closed
    • the additional browser pane shall have only "Expand" and "Close" buttons
  • Add the ability to open a first location from the search results list by Enter-press - when searching location by the name in the unified coordinates and search control, e.g.:
    image
    If user will press Enter in this case - the KRAS gene shall be opened.
    The ability to open manually a certain item from the list - by click it - shall remain as previously.
@NShaforostov NShaforostov added kind/enhancement New feature or request sys/gui Issues related to the web gui labels Dec 9, 2021
rodichenko added a commit that referenced this issue Dec 10, 2021
@Tatyana2022
Copy link
Collaborator

Tatyana2022 commented Dec 16, 2021

Bug was found:
Enter button does not work with "<COORDINATE.>" and "<CHR_NAME>:<START_COORDINATE>-<FINISH_COORDINATE>" format

Steps to reproduce:

  1. Go to NGB
  2. Go to DATASETS panel
  3. Select SV_Sample2 dataset
  4. Go to BROWSER panel
  5. Select 4 chromosome in dropdown menu
  6. Set following coordinates in the field: 25665006 4:49096-50124
  7. Click Enter button on keyboard

Expected result:
2 BROWSER panels are opened.
1)CHR4: 25665006 should be displayed in the main panel
2) CHR4:49096-50124 should be displayed in the second panel

Actual result:
Enter button is not active

Extra Details:
The same behavior for coordinates where <FEATURE_NAME> entered first
@mzueva @rodichenko

Verified

@Tatyana2022
Copy link
Collaborator

Tatyana2022 commented Dec 16, 2021

Bug was found:
Positions are not displayed with the following coordinate input format: "<COORDINATE.>" and "<COORDINATE.>"

Steps to reproduce:

  1. Go to NGB
  2. Go to DATASETS panel
  3. Select SV_Sample2 dataset
  4. Go to BROWSER panel
  5. Select 4 chromosome in dropdown menu
  6. Set following coordinates in the field: 25665006 25665003
  7. Click Enter button on keyboard

Expected result:
2 BROWSER panels are opened.
1)CHR4 should be displayed with position 25665006
2) CHR4 should be displayed in the second panel with position 25665003*

Actual result:
Сoordinates are displayed for the entire length of the chromosome

Extra details:
The same behavior for:
<CHR_NAME>: and <COORDINATE.>
<CHR_NAME>: and <CHR_NAME>:
<CHR_NAME>: and <CHR_NAME>:<START_COORDINATE>-<FINISH_COORDINATE>

@mzueva @rodichenko
Verified

@rodichenko
Copy link
Collaborator

Bug was found: Enter button does not work with "<COORDINATE.>" and "<CHR_NAME>:<START_COORDINATE>-<FINISH_COORDINATE>" format

Bug was found: Positions are not displayed with the following coordinate input format: "<COORDINATE.>" and "<COORDINATE.>"

@Tatyana2022 should be fixed with 6f8ce02

@NShaforostov
Copy link
Collaborator Author

Docs were added via #724 and located here.

@NShaforostov NShaforostov added the state/has-doc Issues that have documentation label Dec 29, 2021
@mzueva mzueva closed this as completed Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request state/has-doc Issues that have documentation sys/gui Issues related to the web gui
Projects
None yet
Development

No branches or pull requests

4 participants