Skip to content

Commit

Permalink
Small fixes (#261)
Browse files Browse the repository at this point in the history
* Removing outdated version property from docker-compose
* Removing unused package.json file
* Renaming BACKEND_ENDPOINT env var ref to PIPELINE_DIRECTORY
  • Loading branch information
epacke authored Nov 19, 2024
1 parent 4fd10b4 commit 058ef4b
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 12 deletions.
1 change: 0 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
version: "3"
services:
pipeline-ui:
build: "./pipeline-ui"
Expand Down
2 changes: 1 addition & 1 deletion pipeline-ui/backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "index.js",
"scripts": {
"start": "node ./build/index.js",
"dev": "cross-env NODE_ENV=DEV BACKEND_ENDPOINT=../../logstash/logstash-config/pipeline nodemon ./src/index.ts",
"dev": "cross-env NODE_ENV=DEV PIPELINE_DIRECTORY=../../logstash/logstash-config/pipeline nodemon ./src/index.ts",
"lint": "eslint ./src/**/*.ts",
"test": "echo \"Error: no test specified\" && exit 1",
"build": "tsc"
Expand Down
4 changes: 2 additions & 2 deletions pipeline-ui/backend/src/api/v1/pipelines/getpipelines.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import path from 'path';
import fs from 'fs';
import BACKEND_ENDPOINT from '../../../constants/BackendEndpoint';
import PIPELINE_DIRECTORY from '../../../constants/PipelineDirectory';

export interface IPipeline {
name: string,
Expand Down Expand Up @@ -34,7 +34,7 @@ function fromDir(startPath: string, filter: string): string[] {

// Get pipeline configs from the pipeline directory
const getConfigFiles = () => {
const configFiles = fromDir(BACKEND_ENDPOINT, '.conf');
const configFiles = fromDir(PIPELINE_DIRECTORY, '.conf');

const pipeLines: IPipeline[] = [];
for (const configFilePath of configFiles) {
Expand Down
2 changes: 0 additions & 2 deletions pipeline-ui/backend/src/constants/BackendEndpoint.ts

This file was deleted.

2 changes: 2 additions & 0 deletions pipeline-ui/backend/src/constants/PipelineDirectory.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export default process.env.PIPELINE_DIRECTORY ||
'/usr/src/pipeline';
6 changes: 0 additions & 6 deletions pipeline-ui/package-lock.json

This file was deleted.

0 comments on commit 058ef4b

Please sign in to comment.