Fixed content error when response is binary file #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With return_raw set to true, I got wrong content in the response data when trying to proxy an API that returns an mp3 file.
Seems that we are using the response.text field even for binary content.
And what happens inside response.text is:
content = str(self.content, errors='replace')
And then we encode the result string with utf-8.
Fixed that by setting the content field instead in the HttpResponse.
A test case for the return raw case is provided.