Fix this in a functional component for ShallowRenderer (#13144)

enzymejs · Jul 3, 2018 · 39b18f3 · 39b18f3
1 parent 2e8ad8e
commit 39b18f3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/ReactShallowRenderer.js b/src/ReactShallowRenderer.js
@@ -107,7 +107,11 @@ class ReactShallowRenderer {
 
         this._mountClassComponent(element, this._context);
       } else {
-        this._rendered = element.type(element.props, this._context);
+        this._rendered = element.type.call(
+          undefined,
+          element.props,
+          this._context,
+        );
       }
     }
 

diff --git a/src/__tests__/ReactShallowRenderer-test.js b/src/__tests__/ReactShallowRenderer-test.js
@@ -1407,4 +1407,15 @@ describe('ReactShallowRenderer', () => {
     instance.setState(state => ({count: state.count + 1}));
     expect(log).toEqual(['render']);
   });
+
+  it('should not get this in a functional component', () => {
+    const logs = [];
+    function Foo() {
+      logs.push(this);
+      return <div>foo</div>;
+    }
+    const shallowRenderer = createRenderer();
+    shallowRenderer.render(<Foo foo="bar" />);
+    expect(logs).toEqual([undefined]);
+  });
 });