Fix an issue w/ cleaning up global.document. #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Mar 23, 2017
src/Utils.js
Outdated
| @@ -222,6 +222,11 @@ export function withSetStateAllowed(fn) { | |||
| fn(); | |||
| if (cleanup) { | |||
| delete global.document; | |||
| // This works around a bug in node/jest in that developers aren't able to | |||
There was a problem hiding this comment.
can this be done before deleting it, so that it's always set to undefined, and then deleted when possible?
Except in the most recent versions of node, developers are unable to delete things from global when running code in a node vm. This means that enzyme is failing to clean up after itself when temporarily defining global.document for setState calls. This papers over the issue by explicitly setting global.document to undefined before attempting to delete. If the delete succeeds, the undefined value will be removed. Relevant jest issue - jestjs/jest#3152 Relevant node pr - nodejs/node#11266
gdborton
force-pushed
the
fix-global-deletion
branch
from
cc05b8a
to
9634269
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except in the most recent versions of node, developers are unable to delete
things from global when running code in a node vm. This means that enzyme is
failing to clean up after itself when temporarily defining global.document for
setState calls.
This papers over the issue by explicitly setting global.document to undefined
if it failed to be deleted.
Relevant jest issue - jestjs/jest#3152
Relevant node pr - nodejs/node#11266