fixed hasClassName in case className is not a string and has toString method. #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,6 +27,7 @@ export function childrenOfNode(node) { | |||
|
|
|||
| export function hasClassName(node, className) { | |||
| let classes = propsOfNode(node).className || ''; | |||
| classes = String(classes); | |||
| classes = classes.replace(/\s/g, ' '); | |||
There was a problem hiding this comment.
String(classes).replace would be a bit more succinct, fwiw.
f0rmat1k
force-pushed
the
hasClassName-toString
branch
from
c96eee7 to
2fa3716
Compare
|
@ljharb agreed. fixed. |
|
LGTM |
|
This branch needs to be caught up now. |
|
@blainekasten using merge is ok? |
|
@f0rmat1k looks good, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518