Fix context method for SFCs #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lelandrichardson
force-pushed
the
lmr--fix-context-for-SFCs
branch
from
3872b9d
to
87379d3
Compare
| @@ -123,6 +123,9 @@ export default class ReactWrapper { | |||
| * @returns {ReactComponent} | |||
| */ | |||
| instance() { | |||
| if (this.root !== this) { | |||
| throw new Error('ReactWrapper::instance() can only be called on the root'); | |||
There was a problem hiding this comment.
is there any test for this throw?
There was a problem hiding this comment.
not explicitly... though it would have thrown before (in a different, less informative way) anyway. This method on anything but the root doesn't make a whole lot of sense
lelandrichardson
added a commit
that referenced
this pull request
Mar 18, 2016
Fix context method for SFCs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180