#1628 - componentWillReceiveProps() receives undefined instead of default #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykhailo-riabokon
changed the title
mykhailo-riabokon
changed the title
ljharb
requested changes
Jul 17, 2018
There was a problem hiding this comment.
This test passes for me without your implementation fix - additionally, it passes with <Foo /> and with <Foo className={notUndefined} /> (since I might expect the setProps to be a noop when the prop value is the same as previously).
Are you sure this is still a bug?
ljharb
force-pushed
the
master
branch
2 times, most recently
from
568ebdd
to
0ee548f
Compare
ljharb
approved these changes
Jul 17, 2018
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1628