Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support portals #1338

Merged
merged 3 commits into from
Nov 15, 2017
Merged

Support portals #1338

merged 3 commits into from
Nov 15, 2017

Conversation

louisscruz
Copy link
Contributor

@louisscruz louisscruz commented Nov 9, 2017

This PR adds support for portals.

In making this PR, I followed the CONTRIBUTING.md as closely as possible. This PR essentially adds a test to the PR submitted by @jquense, who should be given credit if this PR is accepted.

I'm not too familiar with the organization of the tests, so you might wish to place the test in a different location. However, it should get the job done.

@ljharb
Copy link
Member

ljharb commented Nov 9, 2017

Thanks. I'd prefer, in the future, if you posted a link to your commit on the original PR, and I can add it there - opening up a new, duplicate PR clutters the repo.

@louisscruz
Copy link
Contributor Author

louisscruz commented Nov 9, 2017 via email

@louisscruz
Copy link
Contributor Author

Any chance I can get a review?

@ljharb
Copy link
Member

ljharb commented Nov 13, 2017

I've made this PR, and #1263, have the same contents, and split up your changes into a separate commit.

@louisscruz
Copy link
Contributor Author

Thanks a ton! Feel free to close this out.

@ljharb
Copy link
Member

ljharb commented Nov 13, 2017

I'll leave this open for now; that way you can push needed changes here, and I'll copy them over to #1263. I'll close and merge both together.

@ljharb ljharb merged commit 89a3977 into enzymejs:master Nov 15, 2017
ljharb added a commit to ljharb/enzyme that referenced this pull request Nov 15, 2017
jquense pushed a commit to jquense/enzyme that referenced this pull request Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants