-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support portals #1338
Support portals #1338
Conversation
Thanks. I'd prefer, in the future, if you posted a link to your commit on the original PR, and I can add it there - opening up a new, duplicate PR clutters the repo. |
Got it, will do.
Louis
… On Nov 8, 2017, at 9:33 PM, Jordan Harband ***@***.***> wrote:
Thanks. I'd prefer, in the future, if you posted a link to your commit on the original PR, and I can add it there - opening up a new, duplicate PR clutters the repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Any chance I can get a review? |
I've made this PR, and #1263, have the same contents, and split up your changes into a separate commit. |
Thanks a ton! Feel free to close this out. |
I'll leave this open for now; that way you can push needed changes here, and I'll copy them over to #1263. I'll close and merge both together. |
015a967
to
6fd680b
Compare
- add Portal support (enzymejs#1150, enzymejs#1263, enzymejs#1338, enzymejs#1345)
- add Portal support (enzymejs#1150, enzymejs#1263, enzymejs#1338, enzymejs#1345)
This PR adds support for portals.
In making this PR, I followed the
CONTRIBUTING.md
as closely as possible. This PR essentially adds a test to the PR submitted by @jquense, who should be given credit if this PR is accepted.I'm not too familiar with the organization of the tests, so you might wish to place the test in a different location. However, it should get the job done.