Fixed confusing prop selector behavior. Added helpful warning #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (propValue === 'false') return false; | ||
|
|
||
| // user provided an unquoted string value | ||
| throw new Error( |
There was a problem hiding this comment.
this should probably be a TypeError
There was a problem hiding this comment.
I also like what's going on this PR with prefacing these errors with Enzyme::Selector
There was a problem hiding this comment.
👍 i know, i know. my laziness is getting the best of me.
lelandrichardson
force-pushed
the
lmr--fix-prop-selector-string-issue
branch
from
1840e29
to
0033fbf
Compare
|
👍 |
lelandrichardson
added a commit
that referenced
this pull request
Jan 20, 2016
Fixed confusing prop selector behavior. Added helpful warning
This was referenced Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @lencioni @ljharb @blainekasten
When users were passing in selectors with a non-quoted string such as
[type=foo]it was causing undesired behavior, matching any component that had thetypeprop. This refactors the logic so that if the string is unquoted (and not an acceptable numeric literal or boolean), we throw a helpful error indicating that it should be quoted.Fixes #127; Closes #129