-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cheerio Update to 1.0.0 is breaking Enzyme 3.11.0 for Node < 18.17.0 #2606
Comments
In the 'master' branch, the version of cheerio package is changed to "=1.0.0-rc.3", which is not updated in the npm registry, so publishing this change should fix the issue for older projects using node < 18.17.0. |
Meanwhile, the solution for this is to add the following in package.json: For yarn: For npm: |
Duplicate of #2558. |
Why was this closed as "not planned"? Will there no longer be any fixes for this library? |
@EJLearner it wasn't, it was closed as a duplicate. See the issue it duplicates, which is fixed, and the next release of enzyme will include it. On Github, issues are closed when the fix lands, not when the fix is published. |
@RaghavAgrawal-TUL-Luxury |
@hanamantk theres no other option, since rc3 is the last cheerio version that’s compatible with enzyme. |
cheerio (https://github.com/cheeriojs/cheerio) has release an official 1.0.0 version after years of Release Candidate ones. cheeriojs/cheerio#4044 cheeriojs/cheerio#4032 cheeriojs/cheerio#3987 We depend on enzyme (https://github.com/enzymejs/enzyme) which depends on cheerio. Enzyme has not correctly locked cheerio RC version: enzymejs/enzyme@cafdb2b They're working on it... enzymejs/enzyme#2558 enzymejs/enzyme#2606 enzymejs/enzyme#2607 enzymejs/enzyme#2608 enzymejs/enzyme#2609 Meanwhile, locking cheerio here allow us to update our dependencies. According to enzyme, Cheerio RC was the last one supported by enzyme, even though RC12 seems to work for us.
cheerio (https://github.com/cheeriojs/cheerio) has released an official 1.0.0 version after years of Release Candidate ones. cheeriojs/cheerio#4044 cheeriojs/cheerio#4032 cheeriojs/cheerio#3987 We depend on enzyme (https://github.com/enzymejs/enzyme) which depends on cheerio. Enzyme has not correctly locked cheerio RC version: enzymejs/enzyme@cafdb2b They're working on it... enzymejs/enzyme#2558 enzymejs/enzyme#2606 enzymejs/enzyme#2607 enzymejs/enzyme#2608 enzymejs/enzyme#2609 Meanwhile, locking cheerio here allow us to update our dependencies. According to enzyme, Cheerio RC was the last one supported by enzyme, even though RC12 seems to work for us.
Currently, on npm registry Enzyme@3.11.0 dependencies look like this:
This caret(^) symbol which is updating the cheerio version for all users is breaking for our application.
Thanks for reporting an issue to us! We're glad you are using and invested in Enzyme.
Before submitting, please read over our commonly reported issues to prevent duplicates!
All common issues
Notoriously common issues
If you haven't found any duplicated issues, please report it with your environment!
Current behavior
Expected behavior
Your environment
API
Version
Adapter
The text was updated successfully, but these errors were encountered: