feat(DogStatsD): parse EXTRA_TAGS to move from metric name into statsd tags #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDeuce
force-pushed
the
godogextratags
branch
2 times, most recently
from
3c57086
to
8c7030c
Compare
JDeuce
changed the title
JDeuce
force-pushed
the
godogextratags
branch
10 times, most recently
from
d25a68f
to
dcbc8a4
Compare
When using the godogstats sink, previously the EXTRA_TAGS would not be emitted as datadog tags. Signed-off-by: Josh Jaques <jjaques@gmail.com>
ysawa0
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the godogstats sink, previously the EXTRA_TAGS would not be emitted as statsd tags but as part of the metric name.
This PR adds additional string processing on the metrics in the dogstatsd sink, in order to emit them in the required format for datadog.
Also update the example regex in readme with a more optimal match example (greedily matches any potential extra dots in the descriptor)