-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup ossf scorecard and codql workflows #466
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
cc @phlax , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmorel-35 thanks - same style nits - indents/ordering etc - but otherwise lgtm
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
yeah yamllint - we wrap it with |
@phlax would it be a lack of rights that explains the failure ? |
seems there are 2 issues - the not sure about |
i dont think it can be permissions as such - its a |
OK ! Everything seems to work now. |
could you fix the indents please - othewise lgtm cc @ysawa0 @mattklein123 would be good to get signoff from a repo maintainer |
"Fixing" the indent means changing the way it is actually done. It seems out of the scope of this PR. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@@ -1,4 +1,4 @@ | |||
FROM alpine:latest | |||
FROM alpine@sha256:51b67269f354137895d43f3b3d810bfacd3945438e94dc5ac55fdac340352f48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So moving forward we should always ref a sha for images and such?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah its generally preferable - but probs we can let dependabot or similar take care of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you.
* setup ossf scorecard and codql workflows Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update scorecard.yml Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> * Update main.yaml Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --------- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com