-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic config update via xDS Management Server #373
Dynamic config update via xDS Management Server #373
Conversation
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
…content string Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
e8e9494
to
dc3d1ed
Compare
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
dc3d1ed
to
b591364
Compare
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Having a controller to handle the RateLimit configurations would be really nice! |
…ds-conf-provider-impl Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Conflicts: go.sum src/config/config_impl.go
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
…ds-conf-provider-impl Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com> Conflicts: go.sum
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Hi @mattklein123, ADS Client implementation is merged envoyproxy/go-control-plane#604 and updated the go-control-plane version to reflect the client implementation. Could you please review this PR? Thanks. |
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I skimmed and in general LGTM. Fine to ship and iterate with the small nit fix, thanks.
envoyproxy#373 (comment) Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Related to envoyproxy#371 Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@alecholmez - is there a resource somewhere that shows how to use the dynamic config updates via xDS to update envoy ratelimit configuration? |
Here is an example xDS server that will update the configuration of the rate limit service https://github.com/envoyproxy/ratelimit/tree/main/examples/xds-sotw-config-server. If you want to configure envoy, refer to this doc https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_features/global_rate_limiting. |
Thank you! |
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Signed-off-by: Renuka Fernando <renukapiyumal@gmail.com>
Description
Fix #201
Design
Tasks