Goroutine leak in DeltaStreamHandler: fix for issue 913: #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyanfoo
changed the title
Signed-off-by: Zhiyan Foo <zhiyanfoo@gmail.com>
Signed-off-by: Zhiyan Foo <zhiyanfoo@gmail.com>
zhiyanfoo
force-pushed
the
zfs/fix-for-issue-913
branch
from
de7363f
to
c5a1fe1
Compare
pkg/server/v3/delta_test.go
Outdated
| err := s.DeltaAggregatedResources(resp) | ||
| require.Error(t, err) | ||
| resp.cancel() | ||
| defer goleak.VerifyNone(t) |
There was a problem hiding this comment.
Shouldn't this be at the top, to be deferred last? It could be expected for some cleanup to be needed before through other defers in order to report no goroutine here
Signed-off-by: Zhiyan Foo <zhiyanfoo@gmail.com>
zhiyanfoo
force-pushed
the
zfs/fix-for-issue-913
branch
from
62a4359
to
f8eb965
Compare
valerian-roche
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test for the go routine leak identified in issue 913. The bug fix is simply to re-use the same logic that already exists for the state-of-the-world StreamHandler.
You can re-create the goroutine leak by running the commit with just the test, and seeing that it fails before the fix.