add SDS support

[kyessenov]

Pending on SDS client implementation.

Contributes to #57

Signed-off-by: Kuat Yessenov kuat@google.com

[taion809]

@kyessenov hows this going? I see there were some updates to this story here: envoyproxy/envoy#1194

[kyessenov]

I put it on hold until SDS got merged into envoy. Seems like it finally did. I'll finish it up tomorrow most likely.

[wozz]

Is there any update on this? I was able to get this working with envoy 1.8.0 in a local test by just merging this branch into master and using a very basic xds server implementation.

[kyessenov]

I'll complete and merge it today. Sorry, fell out of my list, and SDS took some time to land in envoy.

[codecov-io]

Codecov Report

Merging #56 into master will decrease coverage by 5.53%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   94.67%   89.14%   -5.54%     
==========================================
  Files           7        7              
  Lines         451      479      +28     
==========================================
  Hits          427      427              
- Misses         15       42      +27     
- Partials        9       10       +1

Impacted Files	Coverage Δ
pkg/cache/resource.go	94.73% <0%> (-5.27%)	⬇️
pkg/cache/snapshot.go	92.98% <0%> (-7.02%)	⬇️
pkg/server/gateway.go	84.61% <0%> (-4.58%)	⬇️
pkg/server/server.go	82.01% <0%> (-9.71%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1d16b3...b383d5c. Read the comment docs.

[kyessenov]

Coverage drop is expected: it's a bit more work to stub out TLS secrets. Should remain as a TODO.

[taion809]

Hey,
This LGTM; the TODO you mentioned is around adding Secret to tests for TestSnapshotCacheWatch, TestSnapshotCache, etc? I see that Secrets is excluded from the snapshot test and testTypes. Could that todo be added to the issue tracker?

[kyessenov]

@taion809 Adding a TODO to the linked issue.