Fix goroutine leak in server test. #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `TestResponseHandler`, the test runs the server in a goroutine, but doesn't guarantee that the goroutine completes before the end of the test. In addition to simply leaking the goroutine, this can panic if there is an error after the test completes. In that case, it is unnecessarily hard to debug. Signed-off-by: James Peach <jpeach@apache.org>
jpeach
force-pushed
the
test-goroutine-leaks
branch
from
4574c39
to
b815c6f
Compare
alecholmez
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
TestResponseHandler, the test runs the server in a goroutine,but doesn't guarantee that the goroutine completes before the end of
the test. In addition to simply leaking the goroutine, this can panic
if there is an error after the test completes. In that case, it is
unnecessarily hard to debug.
Signed-off-by: James Peach jpeach@apache.org