-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache: rework snapshot api #484
Conversation
24157fd
to
539646d
Compare
Signed-off-by: Alec Holmes <alecholmez@me.com>
286f127
to
6b2ded9
Compare
@jpeach ended up aliasing to string instead of creating a whole new type. Now a lot of the snapshot stuff asks for a |
Signed-off-by: Alec Holmes <alecholmez@me.com>
7fc46ac
to
3fcfef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this seems to be a great improvement, just some minor comments
Signed-off-by: Alec Holmes <alecholmez@me.com>
@snowp just pushed that last change. |
Signed-off-by: Alec Holmes <alecholmez@me.com>
@snowp can we merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
reworks cache api so we no longer need to change function signatures when adding support for new xDS services