fix: ratelimit not working with both headers and cidr matches #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for one rule Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4377 +/- ##
==========================================
+ Coverage 65.83% 65.85% +0.01%
==========================================
Files 203 203
Lines 30699 30700 +1
==========================================
+ Hits 20212 20216 +4
+ Misses 9335 9333 -2
+ Partials 1152 1151 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
arkodg
reviewed
Oct 10, 2024
arkodg
reviewed
Oct 10, 2024
arkodg
reviewed
Oct 10, 2024
zhaohuabing
reviewed
Oct 18, 2024
internal/xds/translator/testdata/in/ratelimit-config/header-and-cidr-matches.yaml
Show resolved
Hide resolved
zhaohuabing
reviewed
Oct 18, 2024
zhaohuabing
previously approved these changes
Oct 18, 2024
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
Signed-off-by: shawnh2 <shawnhxh@outlook.com>
zhaohuabing
approved these changes
Oct 19, 2024
|
/retest |
arkodg
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4351