helm: Remove default cpu limit inside chart

[RomainBelorgey]

What type of PR is this?

• fix: allow to have no cpu limit when chart used as dependency

What this PR does / why we need it:

• Removing the default cpu limit as can't be removed if used as dependency
• CPU limit should be removed on every deployment (not requests)
  #1
  #2
  #3
• Other examples / writings can be found around that, still possible for someone to add back the cpu limit

Which issue(s) this PR fixes:

Fixes #

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (544bd9c) to head (a6af418).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4290      +/-   ##
==========================================
+ Coverage   65.95%   66.02%   +0.07%     
==========================================
  Files         203      203              
  Lines       31154    31154              
==========================================
+ Hits        20547    20569      +22     
+ Misses       9420     9403      -17     
+ Partials     1187     1182       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nezdolik]

@arkodg currently is not possible to have cpu limit empty(unlimited), since value of 500m gets merged from parent chart. This is our values.yaml:

      resources:
        limits:
          memory: 1024Mi
        requests:
          cpu: 500m
          memory: 256Mi

This is the resulting config of a running pod:

    Limits:
      cpu:     500m
      memory:  1Gi
    Requests:
      cpu:      500m
      memory:   256Mi

[arkodg]

hey @RomainBelorgey good to see you here :)
can you run make generate && make testdata && make manifests and commit those changes ?

[RomainBelorgey]

hey @RomainBelorgey good to see you here :) can you run make generate && make testdata && make manifests and commit those changes ?

Good to see you too :)

Thanks, I just run these commands and pushed the changes

[arkodg]

curious why this is deleted
this is why make gen-check is failing

[zirain]

@RomainBelorgey can you address arko's comment?

[RomainBelorgey]

Sorry got sidetracked to something else 😅
I readded manually persistentVolumeClaimRetentionPolicy on the 2 files where it was removed. Hope that it will fix the check

[arkodg]

np @RomainBelorgey, I suggest rerunning 'make generate' and commiting those change or looking at the CI to see which test files you've missed and editing them

[zirain]

@RomainBelorgey can you fix this, want to land this in v1.2.

[RomainBelorgey]

@RomainBelorgey can you fix this, want to land this in v1.2.

Normally fixed 🤞

[arkodg]

LGTM thanks !