Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: test for 1000 HTTPRoutes #4287

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Sep 19, 2024

No description provided.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner September 19, 2024 20:39
@arkodg arkodg requested review from shawnh2 and a team September 19, 2024 20:39
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.73%. Comparing base (d9dd4e6) to head (8af3621).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4287      +/-   ##
==========================================
+ Coverage   65.70%   65.73%   +0.03%     
==========================================
  Files         210      210              
  Lines       31432    31432              
==========================================
+ Hits        20652    20663      +11     
+ Misses       9587     9578       -9     
+ Partials     1193     1191       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shawnh2
Copy link
Contributor

shawnh2 commented Sep 20, 2024

/retest

@shawnh2
Copy link
Contributor

shawnh2 commented Sep 20, 2024

Wait for the benchmark report. 🫣

@qicz
Copy link
Member

qicz commented Sep 20, 2024

IMO, not only routes but also secrets and configmaps.

@qicz
Copy link
Member

qicz commented Sep 20, 2024

/retest

@arkodg
Copy link
Contributor Author

arkodg commented Sep 20, 2024

seeing this error

2024-09-20T04:21:25.7708266Z ##[error]internal/cmd/options/global.go:10:2: k8s.io/cli-runtime@v0.31.1: Get "https://proxy.golang.org/k8s.io/cli-runtime/@v/v0.31.1.zip": stream error: stream ID 1; PROTOCOL_ERROR

@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 24, 2024

/retest

@shawnh2
Copy link
Contributor

shawnh2 commented Sep 27, 2024

seems 1000 httproutes will cause oom, shall we try 700?

@zirain
Copy link
Contributor

zirain commented Oct 22, 2024

give one more try after #4454 merged.

@zirain
Copy link
Contributor

zirain commented Oct 23, 2024

@arkodg looks we're good now.

@arkodg arkodg requested review from a team October 23, 2024 00:39
@arkodg
Copy link
Contributor Author

arkodg commented Oct 23, 2024

Metrics

Test Name Envoy Gateway Memory (MiB) Envoy Gateway CPU (s) Envoy Proxy Memory (Avg) (MiB) Envoy Proxy CPU (Avg) (s)
scale-up-httproutes-10 107.11 0.74 25.85 30.44
scale-up-httproutes-50 136.46 1.42 31.97 60.84
scale-up-httproutes-100 136.98 2.75 38.13 91.64
scale-up-httproutes-300 141.98 14.64 60.31 124.75
scale-up-httproutes-500 157.41 26.76 80.52 158.63
scale-up-httproutes-1000 179.77 57.89 130.77 197.64
scale-down-httproutes-500 164.67 85.83 130.91 233.84
scale-down-httproutes-300 152.14 96.66 131.07 266.26
scale-down-httproutes-100 146.73 106.85 127.11 298.33
scale-down-httproutes-50 161.01 107.92 127.04 329.02
scale-down-httproutes-10 202.45 108.52 126.36 359.48

@zirain
Copy link
Contributor

zirain commented Oct 23, 2024

the last two seems a little strange

@arkodg arkodg merged commit 7188dad into envoyproxy:main Oct 23, 2024
23 of 24 checks passed
@arkodg arkodg deleted the httproute-1000 branch October 23, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants