Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address github action lint comments #2414

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jan 6, 2024

What type of PR is this?

chore

What this PR does / why we need it:

address github actions lint comment that shown in recent PRs.

image

Signed-off-by: Shawnh2 <shawnhxh@outlook.com>
@shawnh2 shawnh2 requested a review from a team as a code owner January 6, 2024 10:22
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af0d693) 64.56% compared to head (5f82b42) 64.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2414      +/-   ##
==========================================
+ Coverage   64.56%   64.61%   +0.04%     
==========================================
  Files         115      115              
  Lines       17200    17200              
==========================================
+ Hits        11106    11113       +7     
+ Misses       5388     5382       -6     
+ Partials      706      705       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member

zirain commented Jan 6, 2024

/retest

@tmsnan tmsnan self-requested a review January 7, 2024 02:53
@zirain zirain merged commit d57b3fd into envoyproxy:main Jan 7, 2024
17 checks passed
@shawnh2 shawnh2 deleted the chore/indent-comment branch January 8, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants