ci: add bazel.release envoy-debug-sym binary to Docker image. #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the opt build with debug symbols to help folks using the lyft/envoy Docker image.
|
I agree with what @kflynn just said in Gitter. Can we just default to including a build with symbols and forget stripped in the pushed images. If people want to strip the symbols they can should be able to do it themselves. Also, I think we are supposed to be building an alpine image with symbols now, but I think it got broken in bazel conversion: https://github.com/lyft/envoy/blob/master/ci/build_alpine_container/Dockerfile-envoy-alpine-debug Can we reconcile that also? |
mattklein123
approved these changes
May 12, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Use v4only for CircleCI **What this PR does / why we need it**: Fix CircleCI presubmit failure **Which issue this PR fixes* **Release note**: ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the opt build with debug symbols to help folks using the lyft/envoy Docker image.