-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lds: Add HTTP API listener. #8170
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
677d65b
Add HTTP API listener.
markdroth 3799372
Add missing BUILD dependency.
markdroth c860458
Add very basic client capability propoposal to Node message.
markdroth 33c5759
Add next-major-version comment.
markdroth 0203af1
Remove port mapping and capability mechanism.
markdroth 7df2ae1
Move API listener config to its own message using a oneof.
markdroth 137a963
Move ApiListener proto to config tree.
markdroth 6039c6d
Remove gogoproto.
markdroth 20fb3f5
Switch from oneof to Any to avoid circular dependency for go protos.
markdroth 1be606a
Change package name.
markdroth 7442342
Fix package name used in lds.proto.
markdroth 265c5ae
Rename directory.
markdroth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
load("@envoy_api//bazel:api_build_system.bzl", "api_proto_library_internal", "api_proto_package") | ||
|
||
licenses(["notice"]) # Apache 2 | ||
|
||
package_group( | ||
name = "friends", | ||
packages = [ | ||
"//envoy/api/v2", | ||
], | ||
) | ||
|
||
api_proto_package() | ||
|
||
api_proto_library_internal( | ||
name = "api_listener", | ||
srcs = ["api_listener.proto"], | ||
visibility = [":friends"], | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
syntax = "proto3"; | ||
|
||
package envoy.config.listener.v2; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: also change the directory to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
||
option java_outer_classname = "ApiListenerProto"; | ||
option java_multiple_files = true; | ||
option java_package = "io.envoyproxy.envoy.config.api_listener.v2"; | ||
|
||
import "google/protobuf/any.proto"; | ||
|
||
// [#not-implemented-hide:] | ||
// Describes a type of API listener, which is used in non-proxy clients. The type of API | ||
// exposed to the non-proxy application depends on the type of API listener. | ||
message ApiListener { | ||
// The type in this field determines the type of API listener. At present, the following | ||
// types are supported: | ||
// envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager (HTTP) | ||
// [#next-major-version: In the v3 API, replace this Any field with a oneof containing the | ||
// specific config message for each type of API listener. We could not do this in v2 because | ||
// it would have caused circular dependencies for go protos: lds.proto depends on this file, | ||
// and http_connection_manager.proto depends on rds.proto, which is in the same directory as | ||
// lds.proto, so lds.proto cannot depend on this file.] | ||
google.protobuf.Any api_listener = 1; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with this. It would be nice to subsume socket-based listener fields to their own message.