Use git grep as opposed to system grep #7245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebello95
previously approved these changes
Jun 12, 2019
When running on a system where BSD grep is on the PATH the check fails because bsd-grep follows symlinks on `grep -r`. This causes the check to find all the transitive dependencies that are using git on the `bazel-envoy` symbolic link directory Signed-off-by: Martin Conte Mac Donell <martin@lyft.com>
lizan
approved these changes
Jun 12, 2019
mattklein123
approved these changes
Jun 12, 2019
|
@mattklein123 just for your mental sanity: this -does- happen upstream on osx environments that don’t have gnu-grep first on the PATH. I repro’ed with a fresh clone |
|
@Reflejo I see. Is it something about the mobile dev environment that switches this? |
|
@mattklein123 No, bsd grep is just the default on vanilla macos environments (aka any macos that didn't I assume most devs compiling envoy have gnu utils though and the ones that don't are just passing |
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 12, 2019
Updating to include envoyproxy/envoy#7245. Signed-off-by: Michael Rebello <mrebello@lyft.com>
rebello95
added a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Jun 12, 2019
Updating to include envoyproxy/envoy#7245. Signed-off-by: Michael Rebello <mrebello@lyft.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Updating to include #7245. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Updating to include #7245. Signed-off-by: Michael Rebello <mrebello@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on a system where BSD grep is on the PATH the check fails because bsd-grep follows symlinks on
grep -r. This causes the check to find all the transitive dependencies that are using git on thebazel-envoysymbolic link directory.Note this is also a better option because we only care about greping the files that are included in the repo and nothing else
Risk Level: Low
Testing: Done locally, added a bzl file with
remote =strings and it correctly failed.