Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ignore ./bazel-* in check_repositories.sh #7239

Closed
wants to merge 1 commit into from

Commits on Jun 11, 2019

  1. tools: ignore ./bazel-* in check_repositories.sh

    We currently ignore `./bazel-*` in the `check_format.py` script, but not here. Adding it here as an ignored directory as well to prevent lint failures when using `envoy` as a submodule, such as the following:
    
    ```
      Checking repositories definitions
    ./bazel-envoy-mobile/external/bazel_tools/tools/build_defs/repo/git.bzl:68:        remote = ctx.attr.remote,
    ./bazel-envoy-mobile/external/bazel_tools/tools/build_defs/repo/git.bzl:96:    actual_commit = ctx.execute([
    Using git repositories is not allowed.
    To ensure that all dependencies can be stored offline in distdir, only HTTP repositories are allowed.
    ```
    
    Signed-off-by: Michael Rebello <mrebello@lyft.com>
    rebello95 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    67d1ea0 View commit details
    Browse the repository at this point in the history