api: make any serialization stable for go

[kyessenov]

Description: Using proto.MarshalAny results in unstable output due to non-deterministic map ordering. This in turn causes Envoy's diff to reload a config since the hash of the structure changes.
Enable stable marshaler for gogoproto to avoid this problem. See #6252
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a

[kyessenov]

The list of affected protos was found using git grep -l "map<" -- api/

[kyessenov]

/cc @htuch
This is likely the cause of CPU spikes with a repeated push of the same config due to non-deterministic proto serialization.

I don't have rights to re-trigger ASAN build.

[htuch]

@kyessenov how does this get fixed in non-Go languages?

[kyessenov]

@htuch That's a good question. The spec is deliberately unclear (https://developers.google.com/protocol-buffers/docs/proto#maps-features).

C++ has a magic key to sort maps https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/io/coded_stream.h#L856. Other implementations probably have some other mechanisms for stable marshaling.

[duderino]

@PiotrSikora @htuch @lizan We'd love to get this into Istio 1.1. In fact we really can't ship Istio 1.1 without it.

[htuch]

@duderino Ack, just want to make sure we have a clear idea of whether this will be a long term fix. @kyessenov as long as this is stable for C++ at least, then I think we're all good; the main issue I wonder about is Envoy itself doing inconsistent hashing (didn't we have some upstream issue filed on this?). Should we file issues with java-control-plane? Maybe a master issue in the Envoy repo to track all work/languages and link to this in the commit message?

[kyessenov]

Ref #6252

[htuch]

@kyessenov can you update the top comment/commit message in the GH UX with the updated reference? Thanks.

[duderino]

thank you for the quick review and merge