Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash when converting YAML to JSON fails #4110

Merged
merged 7 commits into from
Aug 12, 2018
Merged

Do not crash when converting YAML to JSON fails #4110

merged 7 commits into from
Aug 12, 2018

Commits on Aug 10, 2018

  1. Do not crash when converting yaml to json fails 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    2b42ec8 View commit details
    Browse the repository at this point in the history

  2. Clarify test 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    7611631 View commit details
    Browse the repository at this point in the history

  3. Add valid loading 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    2162723 View commit details
    Browse the repository at this point in the history

  4. Defer the checking at protobuf util 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    2f20370 View commit details
    Browse the repository at this point in the history

  5. Remove superfluous semicolons 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    ac89352 View commit details
    Browse the repository at this point in the history

  6. Remove TODO 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    16b8691 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2018

  1. review comment: remove "&" and fix comment 

    Signed-off-by: Dhi Aurrahman <dio@tetrate.io>
    @dio
    dio committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    c2aff43 View commit details
    Browse the repository at this point in the history