Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream: fix typo (s/lb_type/lb_policy/g) in previous commit. #4051

Merged
merged 1 commit into from
Aug 4, 2018

Conversation

PiotrSikora
Copy link
Contributor

While there, change to uppercase letters to match v2 style.

Risk Level: n/a
Testing: bazel test //test/...
Docs Changes: n/a
Release Notes: n/a

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
Copy link
Contributor Author

I'm not sure how this worked / passed tests with lb_type instead of lb_policy in YAML...

cc @mattklein123

While there, change to uppercase letters to match v2 style.

*Risk Level*: n/a
*Testing*: bazel test //test/...
*Docs Changes*: n/a
*Release Notes*: n/a

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora changed the title upstream: fix typo (s/lb_type/lb_policy/) in previous commit. upstream: fix typo (s/lb_type/lb_policy/g) in previous commit. Aug 3, 2018
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mattklein123 mattklein123 merged commit a614808 into envoyproxy:master Aug 4, 2018
mattklein123 pushed a commit that referenced this pull request Aug 4, 2018
While there, change to uppercase letters to match v2 style.

*Risk Level*: n/a
*Testing*: bazel test //test/...
*Docs Changes*: n/a
*Release Notes*: n/a

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
(cherry picked from commit a614808)

Signed-off-by: Matt Klein <mklein@lyft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants