Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ratelimit: Add ratelimit custom response headers #4015

Merged
merged 4 commits into from
Aug 16, 2018
Merged

ratelimit: Add ratelimit custom response headers #4015

merged 4 commits into from
Aug 16, 2018

Commits on Aug 2, 2018

  1. ratelimit: Add ratelimit custom response headers 

      - Ability to add custom response headers from ratelimit
    service/filter
  - For both (LimitStatus::OK and LimitStatus::OverLimit) custom
    headers are added if RLS service sends headers
  - For LimitStatus:OK, we temporarily store the headers and add
    them to the response (via Filter::encodeHeaders())

*Risk Level*: Low

*Testing*: unit and integration tests added. Verified with modified
 github.com/lyft/ratelimit service. Passes "bazel test //test/..." in
 Linux

*Docs Changes*: protobuf documentation updated

*Release Notes*: ratelimit: support for adding custom http headers
 from ratelimit service

Fixes envoyproxy#3555

Signed-off-by: Suresh Kumar <suresh@freshdesk.com>
    @surki
    surki authored and Suresh Kumar committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    b43d561 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Avoid header addition code duplication 

    Signed-off-by: Suresh Kumar <suresh@freshdesk.com>
    @surki
    surki authored and Suresh Kumar committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    5519480 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Added addHeaders utility function in Envoy::Http::HeaderUtility 

    Signed-off-by: Suresh Kumar <suresh@freshdesk.com>
    @surki
    surki authored and Suresh Kumar committed Aug 14, 2018
    Configuration menu
    Copy the full SHA
    ae4e1aa View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. Add test coverage for encoder and perf improvement for no headers 

    Signed-off-by: Suresh Kumar <suresh@freshdesk.com>
    @surki
    surki authored and Suresh Kumar committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    e7ddb39 View commit details
    Browse the repository at this point in the history