deps: Update proxy_wasm_cpp_host -> c4d7bb0, wasmtime -> 24.0.2, wamr -> 2.2.0
#37868
Conversation
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> Signed-off-by: Matt Leon <mattleon@google.com>
Signed-off-by: Matt Leon <mattleon@google.com>
|
Hi @leonm1, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
/assign @mpwarres |
|
leonm1 is not allowed to assign users. |
|
@botengyao and @wbpcode FYI |
bazel/repositories.bzl
Outdated
| ) | ||
|
|
||
| # This isn't needed in builds with a single Wasm engine, but "bazel query" | ||
| # complains about a missing dependency, so point it at the regular target. | ||
| native.bind( | ||
| name = "prefixed_wasmtime", | ||
| actual = "@com_github_wasm_c_api//:wasmtime_lib", | ||
| actual = "@com_github_wasmtime//:prefixed_wasmtime_lib", |
There was a problem hiding this comment.
Does anything break if this native.bind call is removed altogether? I don't see prefixed_wasmtime actually referenced anywhere in Envoy build rules, and if there is somehow a need for it, perhaps it is already satisfied by @com_github_wasmtime//:prefixed_wasmtime_lib without this added target?
Note that prefixed_wasmtime_lib from proxy-wasm-cpp-host (i.e. the new effective definition) is not quite the same as the old one, which was purely an alias--proxy-wasm-cpp-host's prefixed_wasmtime_lib appears to incorporate a bunch of symbol rewrites (which if anything fits the name better): genrule. That said, I doubt this difference matters to Envoy so long as compilation still succeeds. But if we can remove the rule altogether, that seems simpler to me.
There was a problem hiding this comment.
+1 if we can get rid of the bind altogether it will assist transitioning to bzlmod
There was a problem hiding this comment.
I didn't have any issues running bazel build --define=wasm=wasmtime //source..., bazel test --define=wasm=wasmtime //test/... or bazel query //... after removing the prefixed_wasmtime. Done.
There was a problem hiding this comment.
I think the prefixed builds were for multi engine support; not sure if Envoy supports it, but that's my understanding of the reason
Signed-off-by: Matt Leon <mattleon@google.com>
repokitteh-read-only
bot
removed
the
deps
…`wamr` -> 2.2.0 (envoyproxy#37868) Commit Message: deps: Update `proxy_wasm_cpp_host` -> c4d7bb0, `wasmtime` -> 24.0.2, `wamr` -> 2.2.0 Additional Description: proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0 Risk Level: low Testing: `bazel test test/...` passes, with `--define=wasm=v8`, `--define=wasm=wamr`, and `--define=wasm=wasmtime`. Docs Changes: None. Release Notes: Mentioned new support for [Go SDK](github.com/proxy-wasm/proxy-wasm-go-sdk) plugins. Supercedes envoyproxy#36880 and envoyproxy#36857 --------- Signed-off-by: Matt Leon <mattleon@google.com> Signed-off-by: Keith Mattix II <keithmattix@microsoft.com> Co-authored-by: Ryan Northey <ryan@synca.io> Co-authored-by: Keith Mattix II <keithmattix@microsoft.com> Signed-off-by: Yueren Wang <yuerenwang@lyft.com>
Commit Message: deps: Update
proxy_wasm_cpp_host-> c4d7bb0,wasmtime-> 24.0.2,wamr-> 2.2.0Additional Description: proxy-wasm/proxy-wasm-cpp-host@f199214...c4d7bb0
Risk Level: low
Testing:
bazel test test/...passes, with--define=wasm=v8,--define=wasm=wamr, and--define=wasm=wasmtime.Docs Changes: None.
Release Notes: Mentioned new support for Go SDK plugins.
Supercedes #36880 and #36857