Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bazel changes to build on Windows #3786

Closed
wants to merge 11 commits into from
Closed

build: bazel changes to build on Windows #3786

wants to merge 11 commits into from

Commits on Jul 3, 2018

  1. Bazel / build file changes to build on Windows 

    This commit just contains the build changes required to build envoy on
Windows. As is, it will not compile without code changes. We expect to
add the code changes in an upcoming PR

Signed-off-by: Sam Smith <sesmith177@gmail.com>
Signed-off-by: Amin Jamali <ajamali@pivotal.io>
    @sesmith177
    sesmith177 authored and Amin Jamali committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    e2ab992 View commit details
    Browse the repository at this point in the history

  2. Tag native cc_proto_library as "manual" 

    This is so it doesn't build when Linux ci runs
`bazel build @envoy_api//envoy/...`

Only one of the pgv_cc_proto_library or the native cc_proto_library
can build at a time.

Signed-off-by: Amin Jamali <ajamali@pivotal.io>

Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @sesmith177
    sesmith177 authored and Amin Jamali committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    5bd4ab1 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2018

  1. Use curl instead of wget 

    curl exists in MSYS2 by default.

Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @sesmith177
    Amin Jamali authored and sesmith177 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    1f88b54 View commit details
    Browse the repository at this point in the history

  2. Remove get_workspace_status for windows builds 

    This was used for linkstamping on linux that would not work on windows.

Signed-off-by: Amin Jamali <ajamali@pivotal.io>
    @sesmith177
    sesmith177 authored and Amin Jamali committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    a8eefb8 View commit details
    Browse the repository at this point in the history

  3. BAZEL_SH is the correct bash 

    workstation_setup.ps1 will set BAZEL_SH after installing MSYS2

Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @sesmith177
    Amin Jamali authored and sesmith177 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    80b38b3 View commit details
    Browse the repository at this point in the history

  4. Fix nits 

    Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @sesmith177
    Amin Jamali authored and sesmith177 committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    19e4002 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Use select for prebuilt dependencies 

    Signed-off-by: Natalie Arellano <narellano@pivotal.io>
    @sesmith177 @natalieparellano
    sesmith177 authored and natalieparellano committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    91a8799 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2018

  1. Merge branch 'master' into windows-build-pr 

    Signed-off-by: Matthew Horan <mhoran@pivotal.io>

Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @sesmith177 @mhoran
    sesmith177 authored and mhoran committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    6ad7c28 View commit details
    Browse the repository at this point in the history

  2. Fix Windows build after merge 

    Signed-off-by: Sam Smith <sesmith177@gmail.com>
    @mhoran @sesmith177
    mhoran authored and sesmith177 committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    f1a0385 View commit details
    Browse the repository at this point in the history

  3. Format fixes 

    Signed-off-by: Matthew Horan <mhoran@pivotal.io>

Signed-off-by: Sam Smith <sesmith177@gmail.com>
Signed-off-by: Matthew Horan <mhoran@pivotal.io>
    @sesmith177 @mhoran
    sesmith177 authored and mhoran committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    b5479cf View commit details
    Browse the repository at this point in the history

  4. Simplify nghttp2 patch (hopefully can be upstreamed) 

    Signed-off-by: Sam Smith <sesmith177@gmail.com>

Signed-off-by: Matthew Horan <mhoran@pivotal.io>
    @mhoran @sesmith177
    mhoran authored and sesmith177 committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    e786114 View commit details
    Browse the repository at this point in the history