Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic_modules: enables rustfmt.toml #37295

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Nov 21, 2024

Commit Message: dynamic_modules: enables rustfmt.toml
Additional Description:

This enables the root configuration for rustfmt as a follow up
on #37070 (comment).
Only formatting is done in this commit. There's no change in its code.

Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #37295 was opened by mathetake.

see: more, trace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is to allow editors to auto format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@mathetake mathetake marked this pull request as ready for review November 21, 2024 20:16
@mathetake
Copy link
Member Author

cc @phlax

@soulxu
Copy link
Member

soulxu commented Nov 21, 2024

/assign @mattklein123 @phlax

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 22e7328 into envoyproxy:main Nov 22, 2024
24 checks passed
@mathetake mathetake deleted the dynamic_modules-fmt branch November 22, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants