quic: Don't delay TCP attempt when HTTP/3 status is unknown #37040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredy Wijaya <fredyw@google.com>
fredyw
changed the title
|
/retest |
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
|
/assign @RyanTheOptimist |
RyanTheOptimist
previously approved these changes
Nov 8, 2024
| // The first request could either be HTTP/2 or HTTP/3 because we no longer give HTTP/3 a head | ||
| // start. | ||
| ASSERT_GE(protocols.at(0), Http::Protocol::Http2); | ||
| // TODO(fredyw): In EngFlow CI, HTTP/3 does not work and will use HTTP/2 instead. |
There was a problem hiding this comment.
Wow, that's interesting. Any idea why yet?
There was a problem hiding this comment.
I don't know yet. I pinged EngFlow in Slack. I suspect UDP is blocked or something even after setting https://docs.engflow.com/re/client/platform-options-reference.html#dockernetwork
Signed-off-by: Fredy Wijaya <fredyw@google.com>
Signed-off-by: Fredy Wijaya <fredyw@google.com>
|
/retest |
RyanTheOptimist
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: When HTTP/3 is not known to work, we should attempt both QUIC and TCP at the same time instead of giving QUIC a head start and delaying the TCP connection attempt.
Additional Description: In Envoy Mobile, the HTTP/3 status will be reset upon network change.
Risk Level: low (runtime guarded and the default is false)
Testing: unit and integration tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: quic, mobile
Optional Runtime guard:
envoy.reloadable_features.quic_no_tcp_delay(default is false)