Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_11_proxy: Make inner transport_socket config optional #36414

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

woops

2d09673
Select commit
Loading
Failed to load commit list.
Open

http_11_proxy: Make inner transport_socket config optional #36414

woops
2d09673
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/iOS skipped Oct 3, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/36414/main@2d09673)

tonya11en @tonya11en 2d09673 #36414 merge main@8b5f6e8

http_11_proxy: Make inner transport_socket config optional

http_11_proxy: Make inner transport_socket config optional

Given that the top-level Cluster.transport_socket field is optional and defaults to plaintext, this should also be optional. gRPC is adding support for this transport socket, but they do not have a raw_buffer to explicitly configure. See grpc/proposal#455 (comment) for additional context.

Risk Level: Low.
Testing: Existing tests.
Docs Changes: n/a
Release Notes: Done.

Environment

Request variables

Key Value
ref 36da33d
sha 2d09673
pr 36414
base-sha 8b5f6e8
actor tonya11en @tonya11en
message http_11_proxy: Make inner transport_socket config optional...
started 1727976414.974884
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 32
patch 0
dev true