Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bp/1.30] opentelemetrytracer: avoid exporting when there are no spans #36404

Conversation

joaopgrassi
Copy link
Contributor

@joaopgrassi joaopgrassi commented Oct 1, 2024

Commit Message: Backport #36313
Additional Description:
Risk Level: Low
Testing: Manual
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #35997]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…oxy#36313)

Commit Message: opentelemetrytracer: avoid exporting when there are no
spans
Additional Description: Today, the OpenTelemetry tracer exports a OTLP
request on each interval, even when there are no spans to be sent. The
OTLP is empty, only containing the resource (and its attributes).
Risk Level: Low
Testing: Manual
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes envoyproxy#35997]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional [API
Considerations](https://github.com/envoyproxy/envoy/blob/main/api/review_checklist.md):]

Signed-off-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
@joaopgrassi
Copy link
Contributor Author

CC @wbpcode

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @joaopgrassi

@phlax phlax enabled auto-merge (rebase) October 1, 2024 16:17
@phlax phlax disabled auto-merge October 1, 2024 16:18
@phlax phlax merged commit bcbb3aa into envoyproxy:release/v1.30 Oct 1, 2024
8 of 9 checks passed
@joaopgrassi joaopgrassi deleted the backport/otlp-tracer-avoid-export-empty-messages branch October 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants