Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: add config for max response header size #36231

Merged
merged 12 commits into from
Sep 25, 2024
Merged

http: add config for max response header size #36231

merged 12 commits into from
Sep 25, 2024

Conversation

ggreenway
Copy link
Contributor

Risk Level: Low
Testing: Added tests

@ggreenway
http: add config for max response header size
14525f8 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #36231 was opened by ggreenway.

see: more, trace.

alyssawilk
alyssawilk reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Test failure looks real though
/wait

api/envoy/config/core/v3/protocol.proto Outdated Show resolved Hide resolved
api/envoy/config/core/v3/protocol.proto Outdated Show resolved Hide resolved
test/integration/multiplexed_upstream_integration_test.cc Outdated Show resolved Hide resolved
@ggreenway
fix integration test
bfa34f5 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
improve docs
9dce862 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
test at the limit
4f0aefd 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
verify that request was successful in new test
d86bbd8 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
document codec limits
c4f51dc 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
tests
31b0070 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
alyssawilk
alyssawilk reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more comments. @RyanTheOptimist can I tag you for second pass?

source/common/http/codec_client.cc Show resolved Hide resolved
test/integration/protocol_integration_test.cc Show resolved Hide resolved
alyssawilk
alyssawilk previously approved these changes Sep 24, 2024
View reviewed changes
@ggreenway
HTTP2 -> HTTP/2 in docs
82a44ae 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
remove multiplexed-upstream test; it's duplicate or protocol-test
24fbd12 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
RyanTheOptimist
RyanTheOptimist previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@RyanTheOptimist RyanTheOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this!

@ggreenway
rename new field to max_response_headers_kb
dc84aae 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
@ggreenway
fix proto format
639cfbd 
Signed-off-by: Greg Greenway <ggreenway@apple.com>
markdroth
markdroth reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

api/envoy/config/core/v3/protocol.proto Show resolved Hide resolved
@ggreenway ggreenway enabled auto-merge (squash) September 25, 2024 16:26
@ggreenway ggreenway merged commit 07a8c4a into envoyproxy:main Sep 25, 2024
21 of 22 checks passed
@ggreenway ggreenway mentioned this pull request Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth left review comments

@alyssawilk alyssawilk alyssawilk approved these changes

@RyanTheOptimist RyanTheOptimist RyanTheOptimist left review comments

@mattklein123 mattklein123 Awaiting requested review from mattklein123 mattklein123 is a code owner

Assignees

@alyssawilk alyssawilk

@markdroth markdroth

@RyanTheOptimist RyanTheOptimist

Labels
api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggreenway @alyssawilk @markdroth @RyanTheOptimist