Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/codeql: Fix build setup #36021

Merged
merged 1 commit into from
Sep 9, 2024
Merged

ci/codeql: Fix build setup #36021

merged 1 commit into from
Sep 9, 2024

Conversation

phlax
Copy link
Member

@phlax phlax commented Sep 7, 2024

This fixes the recent issues with codeql caused by removing some of the setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local builds

it also prevents this codepath from being used in RBE, which was a main goal of the previous changes

@phlax phlax changed the title ci/codeql: Fix build setup [WIP] ci/codeql: Fix build setup Sep 7, 2024
@phlax phlax marked this pull request as draft September 7, 2024 11:10
@phlax phlax force-pushed the codeql-fix2 branch 5 times, most recently from 93797c4 to 35cade6 Compare September 9, 2024 09:36
@phlax
Copy link
Member Author

phlax commented Sep 9, 2024

/retest ios

@phlax phlax force-pushed the codeql-fix2 branch 3 times, most recently from a5bc087 to 98c3517 Compare September 9, 2024 12:45
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP] ci/codeql: Fix build setup ci/codeql: Fix build setup Sep 9, 2024
@phlax phlax marked this pull request as ready for review September 9, 2024 15:28
@phlax phlax enabled auto-merge (squash) September 9, 2024 16:24
@phlax phlax merged commit 64bd535 into envoyproxy:main Sep 9, 2024
39 checks passed
unicell added a commit to unicell/envoy that referenced this pull request Sep 11, 2024
* upstream/main: (21 commits)
  Add a CPU utilization resource monitor for overload manager (envoyproxy#34713)
  jwks: Add UA string to headers (envoyproxy#35977)
  exceptions: cleaning up macros (envoyproxy#35694)
  coverage: ratcheting (envoyproxy#36058)
  runtime: load rtds bool correctly as true/false instead of 1/0 (envoyproxy#36044)
  Typo in documentation of http original_src filter (envoyproxy#36060)
  docs: updating meeting info (envoyproxy#36052)
  quic: removes more references to spdy::Http2HeaderBlock. (envoyproxy#36057)
  json: add null support to the streamer (envoyproxy#36051)
  json: make the streamer a template class (envoyproxy#36001)
  docs: Add `apt.envoyproxy.io` install information (envoyproxy#36050)
  ext_proc: elide redundant copy in ext_proc filter factory callback (envoyproxy#36015)
  build(deps): bump yarl from 1.11.0 to 1.11.1 in /tools/base (envoyproxy#36049)
  build(deps): bump multidict from 6.0.5 to 6.1.0 in /tools/base (envoyproxy#36048)
  quic: enable certificate compression/decompression (envoyproxy#35999)
  Geoip fix asan failure (envoyproxy#36043)
  mobile: Fix missing logging output in Swift integration tests (envoyproxy#36040)
  http: minor code clean up to the http filter manager (envoyproxy#36027)
  ci/example: Dont build/test the filter example in Envoy CI (envoyproxy#36038)
  ci/codeql: Fix build setup (envoyproxy#36021)
  ...

Signed-off-by: Qiu Yu <qiuyu@apple.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Sep 26, 2024
This fixes the recent issues with codeql caused by removing some of the
setup in setup_clang.sh

this is a partial revert of that, essentially for containerless local
builds

it also prevents this codepath from being used in RBE, which was a main
goal of the previous changes

Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants