Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: flip async provider runtime guard to default true #35747

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

nbaws
Copy link
Contributor

@nbaws nbaws commented Aug 19, 2024

Commit Message: flip async provider runtime guard to default true
Additional Description: per #30626 (comment)
Risk Level: Low
Testing: Unit
Docs Changes: Changelog
Release Notes:
Platform Specific Features:
[Optional Runtime guard:] envoy_reloadable_features_use_http_client_to_fetch_aws_credentials
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

nbaws added 3 commits August 18, 2024 01:10
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
@nbaws nbaws requested a review from mattklein123 as a code owner August 19, 2024 23:21
Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #35747 was opened by nbaws.

see: more, trace.

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping Envoy clean and improving it, and thanks for updating the docs!
Left a minor comment, but otherwise LGTM!

@adisuissa adisuissa self-assigned this Aug 20, 2024
@adisuissa
Copy link
Contributor

/wait

Signed-off-by: Nigel Brittain <nbaws@amazon.com>
nbaws added 2 commits August 22, 2024 04:16
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Signed-off-by: Nigel Brittain <nbaws@amazon.com>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adisuissa adisuissa merged commit 6277f46 into envoyproxy:main Aug 22, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants