Support dynamic_action in composite filter #33511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
requested review from
mattklein123 and
yanavlasov
as code owners
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…site_dynamic_action Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
/assign @htuch @tyxia @wbpcode @yanavlasov |
test/extensions/filters/http/composite/composite_filter_integration_test.cc
Show resolved
Hide resolved
test/extensions/filters/http/composite/composite_filter_integration_test.cc
Show resolved
Hide resolved
|
/lgtm api |
yanavlasov
approved these changes
Apr 15, 2024
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Apr 18, 2024
--------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
--------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up commit of #33013 to support dynamic_action in composite filter.
In #33013, the dynamic_action support is intentionally left out as there is
cluster manager initialization sequence issue (#33218), which is addressed by #33221.
This PR also extended the composite_filter_integration_test.cc:CompositeFilterIntegrationTest to support three parameters:
Note, this combination is skipped: downstream only filter / config the filter in upstream, as this won't work.
Also, as per-route config is added in HCM, i.e, downstream, thus all the per-route tests are only done with filter configured in downstream.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]