gRPC: Implement max_receive_message_length in envoy gRPC #32711
Merged
+49
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: tyxia <tyxia@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: tyxia <tyxia@google.com>
…ecv_length Signed-off-by: tyxia <tyxia@google.com>
|
/retest |
|
/assign @yanavlasov @htuch |
tyxia
changed the title
htuch
reviewed
Mar 8, 2024
…ecv_length Signed-off-by: tyxia <tyxia@google.com>
|
/retest |
|
/wait-any |
|
Will wait for Lizan's comment to be addressed. /wait |
Signed-off-by: tyxia <tyxia@google.com>
|
Sorry for delay. Release note has been added. PTAL @htuch @yanavlasov @lizan |
…ecv_length Signed-off-by: tyxia <tyxia@google.com>
|
gentle ping @htuch @yanavlasov @lizan |
htuch
approved these changes
Apr 3, 2024
lizan
approved these changes
Apr 3, 2024
yanavlasov
approved these changes
Apr 4, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
…32711) --------- Signed-off-by: tyxia <tyxia@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over-frame-limit error can now be surfaced from gRPC codec level after PR #32511
Envoy gRPC client can leverage this to implement max_recevie_meassage_length with config field. This field is defaulted to 0, which means no limits.
error status will be improved by #32676