-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/examples: Improve CI config #28445
Conversation
243b777
to
a66f1e7
Compare
1d427cb
to
e0e748b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
@wbpcode i spotted an issue with one of the template vars that should be fixed also flagging that when this lands it will fail initially as the workflow that azp triggers will have moved #28459 should fix that, the only way to avoid this would have been to first copy the wf, and then change, and then remove old etc |
Pull request was converted to draft
reWIPping while i test/fix |
should be fixed |
fd746e4
to
c0fbd74
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]