ci: Add github workflow for verify examples #27371
Conversation
phlax
changed the title
phlax
force-pushed
the
gh-verify-wf
branch
2 times, most recently
from
f6b4bf0
to
42a38f4
Compare
phlax
changed the title
|
This works in my testing (https://github.com/phlax/envoy/actions/runs/4957479555/jobs/8869203763) I think it will need a couple more iterations, but would be good to land so we can start testing it properly |
|
also worth mentioning is that the couple of times ive ran it, it seems to be a minute or 2 quicker than running in azp, i guess better connectivity - ~same machines |
phlax
force-pushed
the
gh-verify-wf
branch
2 times, most recently
from
544a323
to
47bad97
Compare
phlax
changed the title
|
added the implementation azp side, which will require a bit of testing |
phlax
force-pushed
the
gh-verify-wf
branch
2 times, most recently
from
f1162e8
to
561fa82
Compare
|
that seems to have worked
|
phlax
force-pushed
the
gh-verify-wf
branch
3 times, most recently
from
cb92e16
to
1a8d34b
Compare
phlax
force-pushed
the
gh-verify-wf
branch
3 times, most recently
from
2d67937
to
11ffc68
Compare
phlax
changed the title
|
this requires a bit of setup before it can land /wait |
phlax
force-pushed
the
gh-verify-wf
branch
5 times, most recently
from
c7bd38e
to
ae662b0
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
removed
the
deps
Signed-off-by: Ryan Northey <ryan@synca.io>
repokitteh-read-only
bot
added
the
deps
phlax
changed the title
|
@wbpcode i think this will fail CI as it expects the workflow that it sets up - once you lgtm, i will do any infra setup, and then push through on the basis that it should start working once it lands (and will follow up if necessary) |
phlax
removed
the
deps
| authToken: ${{ secrets.GITHUB_TOKEN }} | ||
| context: ${{ inputs.workflowName }} | ||
| state: 'pending' | ||
| sha: ${{ inputs.sha }} |
There was a problem hiding this comment.
last quesion, seems we use the inputs.sha of envoy-verify.yml here directly, is it ok?
There was a problem hiding this comment.
to associate with the PR it needs to to use the actual head ref
you can see the (current) one for this pr eg with:
$ git ls-remote upstream | grep 27371/ | grep head
c159a092033b26b4b2a5adf2cc97b1b5798af43c refs/pull/27371/headthis is what is being passed
(above assumes you have upstream set to envoy repo)
There was a problem hiding this comment.
seems i didnt understand correctly and the question is more one of workflow.inputs i think the workflowName is only necessary due to it being different in the workflow_call - but otherwise it gets the same inputs
repokitteh-read-only
bot
added
the
deps
|
pushing this past the issue that its expecting its own workflow ... |
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: phlax <phlax@users.noreply.github.com>
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
This provides an initial implementation of a github workflow for examples verification
It will require some hookup in azp to make it work
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]