Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mobile] ci: switch to pull_request_target #26109

Closed
wants to merge 7 commits into from
Closed

[mobile] ci: switch to pull_request_target #26109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3b56d83
[mobile] ci: switch to `pull_request_target`
Yannic Mar 15, 2023
a208467
Merge branch 'main' into mobile-pull-request-target
Yannic Mar 16, 2023
5f572a5
add back pull_request for migration
Yannic Mar 16, 2023
5672ac9
Merge remote-tracking branch 'origin/main' into mobile-pull-request-t…
Yannic Mar 17, 2023
2f51b71
restrict token
Yannic Mar 17, 2023
0dbe176
more permissions
Yannic Mar 17, 2023
e748f5c
read-all
Yannic Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/android_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:
Comment on lines +7 to 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the fact that these jobs have both pull_request_target and pull_request set mean that jobs will be scheduled in duplicate? Or is GitHub smart enough to only pick one of these as a trigger?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is not smart enough to see it's the same. The intent is to merge this PR, then ask a repo admin to change the required check (because they count as different checks), and then remove pull_request.

Alternatively, we can always remove the required check, land this with only pull_request_target, and then enable it again. Let me know what you prefer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I'll reassign a repo admin so they can coordinate this


# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/android_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/asan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/cc_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/compile_time_options.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/ios_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/ios_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/perf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/release_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/tsan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@ on:
push:
branches:
- main
pull_request_target:
# TODO(yannic): Remove when #26109 is merged and the required checks migrated
# to `pull_request_target`.
pull_request:

# TODO(yannic): Set to `permissions: {}` after migrating away from GitHub token for RE.
permissions: read-all

concurrency:
group: ${{ github.head_ref-github.workflow || github.run_id }}
cancel-in-progress: true
Expand Down