Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault filter: use correct stat prefix #251

Merged
merged 2 commits into from
Nov 30, 2016
Merged

fault filter: use correct stat prefix #251

merged 2 commits into from
Nov 30, 2016

Conversation

mattklein123
Copy link
Member

No description provided.

@mattklein123
Copy link
Member Author

@lyft/network-team

Copy link
Member

@RomanDzhabarov RomanDzhabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd probably need to have tests explicitly checking for stat name to catch that.

@mattklein123 mattklein123 merged commit d06aec9 into master Nov 30, 2016
@mattklein123 mattklein123 deleted the fault_stats branch November 30, 2016 03:01
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
* Templatize PathMatcher

* make path_matcher.cc ready to move to header

* Move path_matcher to independent build target

* Remove utils from dep
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
mandarjog pushed a commit to mandarjog/envoy that referenced this pull request Aug 14, 2020
* Add tests written using Proxy-Wasm Rust SDK.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: regenerated using published proxy-wasm crate.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* review: fix end_stream parameter in decodeHeaders().

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: this PR adds a few foundational constructs to implement the c API introduced in #225.
The approach take here is to create an Http dispatcher that is able to manage http streams via the APIs introduced in #225. The streams created by the dispatcher can be interacted with in the mobile platform, and ultimately map down to direct injection into the envoy router via upstream envoy constructs (async client, async stream, and the router).

The code introduced here is capable of making a headers only request from platform code, and receiving the corresponding callback in platform code.

Subsequent PRs will implement the other relevant methods to deal with data and trailers.

Risk Level: med - foundational constructs introduced.
Testing: added cpp unit tests, and a CI job to run them.

Signed-off-by: Jose Nino <jnino@lyft.com>
Co-authored-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: this PR adds a few foundational constructs to implement the c API introduced in #225.
The approach take here is to create an Http dispatcher that is able to manage http streams via the APIs introduced in #225. The streams created by the dispatcher can be interacted with in the mobile platform, and ultimately map down to direct injection into the envoy router via upstream envoy constructs (async client, async stream, and the router).

The code introduced here is capable of making a headers only request from platform code, and receiving the corresponding callback in platform code.

Subsequent PRs will implement the other relevant methods to deal with data and trailers.

Risk Level: med - foundational constructs introduced.
Testing: added cpp unit tests, and a CI job to run them.

Signed-off-by: Jose Nino <jnino@lyft.com>
Co-authored-by: Mike Schore <mike.schore@gmail.com>
Signed-off-by: JP Simard <jp@jpsim.com>
arminabf pushed a commit to arminabf/envoy that referenced this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants